refactor: remove build queue for immediate build execution #56
Conversation
Replace the explicit build queue with immediate build execution. Builds now start immediately when created instead of being queued. Key changes: - Delete queue.go and queue_test.go - Remove StatusQueued - builds start with StatusBuilding - Add ErrResourcesExhausted error for resource limit detection - Add 503 response with Retry-After header to OpenAPI spec - Update manager to start builds in goroutines directly - Simplify CancelBuild to only handle running builds - Update RecoverPendingBuilds to start builds immediately - Remove queue-related metrics (queueLength, activeBuilds) - Update tests and documentation If host resources are exhausted during instance creation, the build will fail with a clear error message. The API includes a 503 response type with Retry-After header for future pre-check implementation.
✱ Stainless preview buildsThis PR will update the Edit this comment to update it. It will appear in the SDK's changelogs. ✅ hypeman-typescript studio · code · diff
✅ hypeman-go studio · code · diff
⏳ These are partial results; builds are still running. This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push. |
|
A couple things to consider with the queue removal:
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| if err != nil { | ||
| // Check if this is a resource exhaustion error | ||
| errStr := err.Error() | ||
| if strings.Contains(errStr, "exceeds") && strings.Contains(errStr, "limit") { |
There was a problem hiding this comment.
unclear how this ErrResourcesExhausted error makes it back to the API handler - since executeBuild is called from runBuild which runs in a background goroutine, the caller has already received a 202 by the time this runs. the 503 path in the handler seems unreachable?
There was a problem hiding this comment.
You're absolutely right - that was exactly the issue. I've fixed this by adding a synchronous preflight resource check in CreateBuild that runs before spawning the async goroutine:
// Preflight check: verify resources are available before accepting the build
builderMemory := int64(policy.MemoryMB) * 1024 * 1024
if err := m.instanceManager.CheckResourceAvailability(ctx, policy.CPUs, builderMemory); err != nil {
if errors.Is(err, instances.ErrResourcesExhausted) {
return nil, fmt.Errorf("%w: %v", ErrResourcesExhausted, err)
}
return nil, fmt.Errorf("check resource availability: %w", err)
}Added a new CheckResourceAvailability() method to instances.Manager that checks per-instance and aggregate limits without actually creating an instance. Now the 503 path is reachable when resources are truly exhausted at build creation time.
Also added proper sentinel errors (ErrResourcesExhausted) to both packages so we can use errors.Is() instead of brittle string matching.
Summary
lib/builds/queue.goandlib/builds/queue_test.goErrResourcesExhaustederror and 503 response type for resource exhaustionqueue_positionfieldMotivation
The build queue added complexity without providing significant benefits:
Key Changes
Files Changed
lib/builds/queue.go,lib/builds/queue_test.gomanager.go,types.go,errors.go,metrics.go,storage.goopenapi.yaml, updatedcmd/api/api/builds.gomanager_test.goto remove queue testsREADME.mdto reflect new architectureTest plan
go build ./...- project compilesgo test ./lib/builds/...- all builds package tests passbuildingstatusNote
Removes the in-memory build queue so builds start immediately and adjusts API/behavior to match.
BuildQueue;CreateBuildsets statusbuildingand runs build in background;CancelBuildnow stops the builder instance; recovery restartsbuilding/pushingbuilds; detect resource exhaustion on instance create and map toErrResourcesExhausted.queuedstatus; deprecateBuild.queue_position(always null);POST /buildsnow "created and started"; add503 resources_exhaustedwithRetry-Afterand wire incmd/api/api/builds.go; regenerate OAPI client/server code.lib/builds/queue.goand its tests; adjust recovery to onlybuilding/pushing.github.com/opencontainers/go-digestto direct dep.Written by Cursor Bugbot for commit 81d9976. This will update automatically on new commits. Configure here.